Skip to content

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Sep 6, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Sep 6, 2016
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975 and @icewind1991 to be potential reviewers

@MorrisJobke
Copy link
Member Author

On the next transifex run this will automatically upload the twofactor_backupcodes strings to transifex

@ChristophWurst
Copy link
Member

👍 thx

@rullzer
Copy link
Member

rullzer commented Sep 6, 2016

LGTM

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 6, 2016
@MorrisJobke
Copy link
Member Author

Ummm what?!?!

$ NOCOVERAGE=true TEST_SELECTION=NODB ./autotest.sh sqlite
Using PHP executable /usr/bin/php
Parsing all files in lib/public for the presence of @since or @deprecated on each method...

Using database oc_autotest
Setup environment for sqlite testing on local storage ...
Installing ....
Nextcloud is not installed - only a limited number of commands are available
creating sqlite db
Nextcloud was successfully installed
Testing with sqlite ...
No coverage
/usr/local/bin/phpunit --configuration phpunit-autotest.xml --exclude-group DB --log-junit autotest-results-sqlite.xml  
PHP Fatal error:  Call to undefined method Test\Share20\ManagerTest::createMock() in /drone/src/github.com/nextcloud/server/tests/lib/Share20/ManagerTest.php on line 160
[info] build failed (exit code 255)

the very first PHP unit test crashes?!? ... I will restart it. Lets see :)

@ChristophWurst
Copy link
Member

#1242 was merged 20mins ago, maybe that is causing it

@MorrisJobke
Copy link
Member Author

the very first PHP unit test crashes?!? ... I will restart it. Lets see :)

cc @rullzer

@MorrisJobke
Copy link
Member Author

cc @rullzer

Maybe we revert the changes in .drone.yml and retest everything.

@MorrisJobke MorrisJobke force-pushed the add-twofactor_backupcodes-l10n branch from e0655c8 to d13d1e1 Compare September 6, 2016 12:50
@MorrisJobke
Copy link
Member Author

I rebased on current master. Maybe that is the cause.

@rullzer rullzer merged commit c049559 into master Sep 6, 2016
@rullzer rullzer deleted the add-twofactor_backupcodes-l10n branch September 6, 2016 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants