Fetch lastInsertId only when id null #13086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I always wonder if we should have a separate model for stuff that does nto have an autoincrement ID or no ID at all. |
nickvergessen
approved these changes
Dec 17, 2018
Member
|
Isn't |
Contributor
Author
By default |
Member
|
So then how does this fix it? As on insert of new data it will anyways be null right? |
Member
|
Well @rullzer the problem is the social app uses this for a model without autoincrement, the column is not even in 32bit integer anymore: |
Member
|
Ah it is set there. OK. Yeah I think having a special entity would make sense. But for now lets do this. |
When id column has no autoincrement flag query for lastInsertId fails on postgres because no value has been generated. Call lastInsertId only if id is null. Signed-off-by: Daniel Kesselberg <[email protected]>
Some implementations typehint getId to integer but default is null. Signed-off-by: Daniel Kesselberg <[email protected]>
rullzer
force-pushed
the
bugfix/dont-query-when-id-not-null
branch
from
8fcef56 to
8a952b7
Compare
rullzer
approved these changes
Dec 27, 2018
Contributor
Author
|
/backport to stable15 |
|
backport to stable15 in #13278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When id column has no autoincrement flag query for lastInsertId fails
on postgres because no value has been generated. Call lastInsertId only
if id is null.
Could you consider a backport? Social App does not work on postgres without this like reported here #12465 (comment). Not sure how "safe" it is to backport it.