Skip to content

Fetch lastInsertId only when id null #13086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Dec 27, 2018
Merged

Fetch lastInsertId only when id null #13086

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21b80a8
Fetch lastInsertId only when id null
kesselb Dec 15, 2018
8a952b7
Access id property without getter.
kesselb Dec 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fetch lastInsertId only when id null 
When id column has no autoincrement flag query for lastInsertId fails
on postgres because no value has been generated. Call lastInsertId only
if id is null.

Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb @rullzer
kesselb authored and rullzer committed Dec 24, 2018
commit 21b80a89b0d34318c257cc93eba9333228f1854e
4 changes: 3 additions & 1 deletion lib/public/AppFramework/Db/QBMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ public function insert(Entity $entity): Entity {

$qb->execute();

$entity->setId((int) $qb->getLastInsertId());
if($entity->getId() === null) {
$entity->setId((int)$qb->getLastInsertId());
}

return $entity;
}
Expand Down