Skip to content

[PoC] Use webpack for files_sharing #13649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliusknorr wants to merge 4 commits into from
Closed

[PoC] Use webpack for files_sharing #13649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fd27f8
Move files_sharing to webpack
juliusknorr Jan 17, 2019
bd13b47
Add vue app for collaboration resources
juliusknorr Jan 17, 2019
fc9d2c4
fixup! Move files_sharing to webpack
juliusknorr Jan 17, 2019
83fc4b0
fixup! Move files_sharing to webpack
juliusknorr Jan 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! Move files_sharing to webpack
  • Loading branch information
@juliusknorr
juliusknorr committed Jan 17, 2019
commit 83fc4b0380ba9704a5c105eb41135f5f1157940e
1 change: 0 additions & 1 deletion apps/files_sharing/appinfo/app.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
'OCA\Files::loadAdditionalScripts',
function() {
\OCP\Util::addStyle('files_sharing', 'mergedAdditionalStyles');
\OCP\Util::addScript('files_sharing', 'dist/files_sharing');
}
);

Expand Down
3 changes: 1 addition & 2 deletions apps/files_sharing/list.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
// gridview not available for ie
$tmpl->assign('showgridview', $showgridview && !$isIE);

OCP\Util::addScript('files_sharing', 'app');
OCP\Util::addScript('files_sharing', 'sharedfilelist');
OCP\Util::addScript('files_sharing', 'dist/files_sharing');

$tmpl->printPage();
4 changes: 4 additions & 0 deletions apps/files_sharing/src/files_sharing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ __webpack_nonce__ = btoa(OC.requestToken)
// eslint-disable-next-line
__webpack_public_path__ = OC.linkTo('files_sharing', 'js/dist/')

import '../js/app'
import '../js/sharedfilelist'
import '../js/sharetabview'
import '../js/share'
import '../js/sharebreadcrumbview'

window.OCA.Sharing = OCA.Sharing