Mount configuration handlers for external storages #14174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
added
enhancement
3. to review
…olders * BackendService (directly accessable via \OC_Server) offers registerConfigHandler * SimpleSubstitutionTrait brings reusable logic for simple string replacments * internal $user replacement mechanism was migrated Signed-off-by: Arthur Schiwon <[email protected]>
* handler registered upon OCA\\Files_External::loadAdditionalBackends event as user_ldap is loaded before files_external * new configuration field "ldapExtStorageHomeAttribute" (not in GUI yet) Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
feature/noid/extstorage-mountconfighandler
branch
from
ff71930 to
685c13e
Compare
Member
Author
|
rebased to resolve merge conflict |
rullzer
approved these changes
Feb 15, 2019
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Looks good to me but I'd like @icewind1991 to have a look as well.
Member
|
Code and documentation seem to disagree between using looks good otherwise |
Member
Author
|
Thx @icewind1991, good catch, i'll fix the doc later this evening. then it also should be good to merge . |
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
4. to release
This was referenced May 17, 2019
Member
|
Regression: #15654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces configuration handlers (and a registration method) for files_external. Previously, replacing of "$user" with the uid was hardcoded.
The LDAP backend was extended to take advantage of this mechanism, implementing a placeholder for "$home".
LDAP config:
External storage config example (one invalid with unreplaced placeholder, and the one valid):