Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Feb 14, 2019

otherwise they will be skipped when the results is being formatted and the
lower-cased result keys do not match.

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@blizzz
Copy link
Member Author

blizzz commented Feb 14, 2019

ah, let me quickly take out adding @property string homeFolderNamingRule to Connection.php as it probably creates a conflict with #14174

otherwise they will be skipped when the results is being formatted and the
lower-cased result keys do not match.

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz force-pushed the fix/noid/ldap-lowercase-request-attributes branch from 743a813 to 5c10a46 Compare February 14, 2019 13:13
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 14, 2019
@blizzz
Copy link
Member Author

blizzz commented Feb 14, 2019

failing tests unrelated → merging

@blizzz blizzz merged commit a80bae3 into master Feb 14, 2019
@blizzz blizzz deleted the fix/noid/ldap-lowercase-request-attributes branch February 14, 2019 14:06
@blizzz
Copy link
Member Author

blizzz commented Feb 14, 2019

/backport to stable15

@blizzz
Copy link
Member Author

blizzz commented Feb 14, 2019

/backport to stable14

@blizzz
Copy link
Member Author

blizzz commented Feb 14, 2019

/backport to stable13

@backportbot-nextcloud
Copy link

backport to stable15 in #14203

@backportbot-nextcloud
Copy link

The backport to stable14 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable13 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: ldap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants