Skip to content

Make appstore app:enable test more robust by repeating if it fails on the first try #14668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Mar 14, 2019
Merged

Make appstore app:enable test more robust by repeating if it fails on the first try #14668

MorrisJobke merged 1 commit into from
Mar 14, 2019

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 13, 2019

Fixes the issue from #14640 (comment)

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 13, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 13, 2019
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 13, 2019

/backport to stable15

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 13, 2019

/backport to stable14

@kesselb
Copy link
Contributor

kesselb commented Mar 14, 2019

Backport will fail because the tests are new. The test only works if app store is available and there is a release of the contacts app. Tests will fail again if you bump version to 17. I think we should disable the tests with the contact app for now.

kesselb
kesselb reviewed Mar 14, 2019
View reviewed changes
@MorrisJobke MorrisJobke force-pushed the fix/noid/make-appstore-test-more-stable branch from 1149cd4 to 2d02f54 Compare March 14, 2019 10:46
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 14, 2019

@kesselb I changed the app to a shipped one.

@MorrisJobke MorrisJobke force-pushed the fix/noid/make-appstore-test-more-stable branch from 2d02f54 to 5b4155b Compare March 14, 2019 12:39
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 14, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16990: failure

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:75
  • tests/acceptance/features/apps.feature:83
Show full log 
  Scenario: View app details for app store apps   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:75
    Given I act as Jane                           # ActorContext::iActAs()
    And I am logged in as the admin               # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                # AppNavigationContext::iOpenTheSection()
    When I click on the "Antivirus for files" app # AppsManagementContext::iClickOnTheApp()
      Row for app Antivirus for files in Apps Management could not be found after 100 seconds (NoSuchElementException)
    Then I see that the app details are shown     # AppsManagementContext::iSeeThatTheAppDetailsAreShown()

  Scenario: Install an app from the app store                     # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:83
    Given I act as Jane                                           # ActorContext::iActAs()
    And I am logged in as the admin                               # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                                # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                                # AppNavigationContext::iOpenTheSection()
      Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
    And I click on the "Antivirus for files" app                  # AppsManagementContext::iClickOnTheApp()
    And I see that the app details are shown                      # AppsManagementContext::iSeeThatTheAppDetailsAreShown()
    Then I download and enable the "Antivirus for files" app      # AppsManagementContext::iDownloadAndEnableTheApp()
    And I see that the "Antivirus for files" app has been enabled # AppsManagementContext::iSeeThatTheAppHasBeenEnabled()

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 14, 2019

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:75
  • tests/acceptance/features/apps.feature:83

Commented in 70f90b8 in #14681

@MorrisJobke MorrisJobke merged commit b7ffbcd into master Mar 14, 2019
@MorrisJobke MorrisJobke deleted the fix/noid/make-appstore-test-more-stable branch March 14, 2019 15:19
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 14, 2019

The backport to stable15 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 14, 2019

The backport to stable14 failed. Please do this backport manually.

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 14, 2019

No need to back port - the command was added to 16.

@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @kesselb @rullzer