Skip to content

Disable fragile tests - part 2 #14681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 5 commits into from
Mar 14, 2019
Merged

Disable fragile tests - part 2 #14681

MorrisJobke merged 5 commits into from
Mar 14, 2019

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 14, 2019

Found while back porting #14640 (#14673 #14672)

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 14, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 14, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 14, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16995: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

  • tests/acceptance/features/app-files.feature:239
Show full log 
  Scenario: rename a file with the details view open                         # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:239
    Given I am logged in                                                     # LoginPageContext::iAmLoggedIn()
    And I open the details view for "welcome.txt"                            # FileListContext::iOpenTheDetailsViewFor()
    When I rename "welcome.txt" to "farewell.txt"                            # FileListContext::iRenameTo()
      Rename input for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    Then I see that the file list contains a file named "farewell.txt"       # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I see that the file name shown in the details view is "farewell.txt" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()

@MorrisJobke MorrisJobke mentioned this pull request Mar 14, 2019
Merged
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 14, 2019

Backports of this are in #14673 and #14672 already

This was referenced Mar 14, 2019
Merged
Merged
ChristophWurst
ChristophWurst approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙊 🙈 🙉

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@MorrisJobke MorrisJobke mentioned this pull request Mar 14, 2019
Merged
@MorrisJobke MorrisJobke merged commit bfe2c19 into master Mar 14, 2019
@MorrisJobke MorrisJobke deleted the forwardport/noid/fragile-tests branch March 14, 2019 22:30
This was referenced Mar 14, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @rullzer @ChristophWurst