Skip to content

Fix translation sync for accessibiltiy #14679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Mar 14, 2019
Merged

Fix translation sync for accessibiltiy #14679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f18d989
Fix translation sync for accessibiltiy
MorrisJobke Mar 14, 2019
b7f0091
Add time between SMB test runs and properly log full changeset
MorrisJobke Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/accessibility/.l10nignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# compiled vue templates
js/accessibility.js
Empty file added apps/accessibility/l10n/.gitkeep
View file
Open in desktop
Empty file.
4 changes: 3 additions & 1 deletion apps/files_external/tests/Storage/SmbTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ public function testNotifyGetChanges() {
$notifyHandler = $this->instance->notify('');
sleep(1); //give time for the notify to start
$this->instance->file_put_contents('/newfile.txt', 'test content');
sleep(1);
$this->instance->rename('/newfile.txt', 'renamed.txt');
sleep(1);
$this->instance->unlink('/renamed.txt');
sleep(1); //time for all changes to be processed

Expand All @@ -119,7 +121,7 @@ public function testNotifyGetChanges() {
];

foreach ($expected as $expectedChange) {
$this->assertContains($expectedChange, $changes, '', false, false); // dont check object identity
$this->assertContains($expectedChange, $changes, 'Actual changes are:' . PHP_EOL . print_r($expected, true), false, false); // dont check object identity
}
}

Expand Down