Skip to content

Fix translation sync for accessibiltiy #14679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 2 commits into from
Mar 14, 2019
Merged

Fix translation sync for accessibiltiy #14679

MorrisJobke merged 2 commits into from
Mar 14, 2019

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 14, 2019

No description provided.

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 14, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 14, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 14, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16989: failure

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:75
Show full log 
  Scenario: View app details for app store apps   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:75
    Given I act as Jane                           # ActorContext::iActAs()
    And I am logged in as the admin               # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                # AppNavigationContext::iOpenTheSection()
      Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
    When I click on the "Antivirus for files" app # AppsManagementContext::iClickOnTheApp()
    Then I see that the app details are shown     # AppsManagementContext::iSeeThatTheAppDetailsAreShown()

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 14, 2019

  • tests/acceptance/features/apps.feature:75

This one is "fixed" in #14681 - so this is ready to get in.

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 14, 2019

And b7f0091 was back ported via #14672 and #14673

ChristophWurst
ChristophWurst approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@MorrisJobke MorrisJobke merged commit 11e8fd4 into master Mar 14, 2019
@MorrisJobke MorrisJobke deleted the fix/noid/l10n-accessibiltiy branch March 14, 2019 15:55
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
@juliusknorr juliusknorr mentioned this pull request Jun 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @rullzer @ChristophWurst