Skip to content

Disable fragile tests - part 2 #14681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 5 commits into from
Mar 14, 2019
Merged

Disable fragile tests - part 2 #14681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
43e9006
Disable failing files app test - act 2
MorrisJobke Mar 14, 2019
caea04d
Disable failing comments app test - act 2
MorrisJobke Mar 14, 2019
70f90b8
Disable failing app management test
MorrisJobke Mar 14, 2019
951dcc1
Disable failing files app test - act 3
MorrisJobke Mar 14, 2019
1d93894
Disable failing files app test - act 4
MorrisJobke Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/acceptance/features/app-comments.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
Feature: app-comments

Scenario: Writing a comment
Given I am logged in
And I open the details view for "welcome.txt"
And I open the "Comments" tab in the details view
When I create a new comment with "Hello world" as message
Then I see a comment with "Hello world" as message
# Scenario: Writing a comment
# Given I am logged in
# And I open the details view for "welcome.txt"
# And I open the "Comments" tab in the details view
# When I create a new comment with "Hello world" as message
# Then I see a comment with "Hello world" as message

# Scenario: open the comments for a different file
# Given I am logged in
Expand Down
72 changes: 36 additions & 36 deletions tests/acceptance/features/app-files.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,16 @@ Feature: app-files
Then I see that the current section is "Shares"
Then I see that the file list contains a file named "welcome.txt"

Scenario: show shares for a second time
Given I am logged in
And I open the "Shares" section
And I see that the current section is "Shares"
And I open the "All files" section
And I see that the current section is "All files"
And I share the link for "welcome.txt"
When I open the "Shares" section
Then I see that the current section is "Shares"
Then I see that the file list contains a file named "welcome.txt"
# Scenario: show shares for a second time
# Given I am logged in
# And I open the "Shares" section
# And I see that the current section is "Shares"
# And I open the "All files" section
# And I see that the current section is "All files"
# And I share the link for "welcome.txt"
# When I open the "Shares" section
# Then I see that the current section is "Shares"
# Then I see that the file list contains a file named "welcome.txt"

# Scenario: show deleted files
# Given I am logged in
Expand Down Expand Up @@ -182,26 +182,26 @@ Feature: app-files
# And I open the Files app
# And I see that the file list contains a file named "welcome.txt"

Scenario: copy a selection to another folder
Given I am logged in
And I create a new folder named "Folder"
And I create a new folder named "Not selected folder"
And I create a new folder named "Destination"
When I select "welcome.txt"
And I select "Folder"
And I start the move or copy operation for the selected files
And I select "Destination" in the file picker
And I copy to the last selected folder in the file picker
Then I enter in the folder named "Destination"
# The files will appear in the destination once the copy operation finishes
And I see that the file list contains a file named "welcome.txt"
And I see that the file list contains a file named "Folder"
And I see that the file list does not contain a file named "Not selected folder"
# The Files app is open again to reload the file list in the root folder
And I open the Files app
And I see that the file list contains a file named "welcome.txt"
And I see that the file list contains a file named "Folder"
And I see that the file list contains a file named "Not selected folder"
# Scenario: copy a selection to another folder
# Given I am logged in
# And I create a new folder named "Folder"
# And I create a new folder named "Not selected folder"
# And I create a new folder named "Destination"
# When I select "welcome.txt"
# And I select "Folder"
# And I start the move or copy operation for the selected files
# And I select "Destination" in the file picker
# And I copy to the last selected folder in the file picker
# Then I enter in the folder named "Destination"
# # The files will appear in the destination once the copy operation finishes
# And I see that the file list contains a file named "welcome.txt"
# And I see that the file list contains a file named "Folder"
# And I see that the file list does not contain a file named "Not selected folder"
# # The Files app is open again to reload the file list in the root folder
# And I open the Files app
# And I see that the file list contains a file named "welcome.txt"
# And I see that the file list contains a file named "Folder"
# And I see that the file list contains a file named "Not selected folder"

Scenario: copy a file in its same folder
Given I am logged in
Expand Down Expand Up @@ -236,12 +236,12 @@ Feature: app-files
And I see that the file list contains a file named "welcome (copy).txt"
And I see that the file list contains a file named "welcome (copy 2).txt"

Scenario: rename a file with the details view open
Given I am logged in
And I open the details view for "welcome.txt"
When I rename "welcome.txt" to "farewell.txt"
Then I see that the file list contains a file named "farewell.txt"
And I see that the file name shown in the details view is "farewell.txt"
# Scenario: rename a file with the details view open
# Given I am logged in
# And I open the details view for "welcome.txt"
# When I rename "welcome.txt" to "farewell.txt"
# Then I see that the file list contains a file named "farewell.txt"
# And I see that the file name shown in the details view is "farewell.txt"

Scenario: marking a file as favorite causes the file list to be sorted again
Given I am logged in
Expand Down
32 changes: 16 additions & 16 deletions tests/acceptance/features/apps.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,20 +72,20 @@ Feature: apps
#Then I see that there some apps listed from the app store
#And I see that the current section is "Files"

Scenario: View app details for app store apps
Given I act as Jane
And I am logged in as the admin
And I open the Apps management
And I open the "Tools" section
When I click on the "Antivirus for files" app
Then I see that the app details are shown
# Scenario: View app details for app store apps
# Given I act as Jane
# And I am logged in as the admin
# And I open the Apps management
# And I open the "Tools" section
# When I click on the "Antivirus for files" app
# Then I see that the app details are shown

Scenario: Install an app from the app store
Given I act as Jane
And I am logged in as the admin
And I open the Apps management
And I open the "Tools" section
And I click on the "Antivirus for files" app
And I see that the app details are shown
Then I download and enable the "Antivirus for files" app
And I see that the "Antivirus for files" app has been enabled
# Scenario: Install an app from the app store
# Given I act as Jane
# And I am logged in as the admin
# And I open the Apps management
# And I open the "Tools" section
# And I click on the "Antivirus for files" app
# And I see that the app details are shown
# Then I download and enable the "Antivirus for files" app
# And I see that the "Antivirus for files" app has been enabled