Skip to content

Conversation

@juliusknorr
Copy link
Member

Theming fixes from #14639

  • Light theming color:
    • On error pages like "File not found"
    • "Forgot password?" on log in is light, should be dark
    • App name in header has boxy background
    • 3 dot icon in share link header is white, should be black
    • First run wizard "next" icon should be dark because the primary color is light -> Fix next arrow on light theming colors firstrunwizard#182
  • Dark theme: "File not found" screen has dark icon, should be white
  • Basically all the content of the .body-login-container should always be white because the container background is dark (#body-login p rule for footer overwrites this, should be more specific)

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me otherwise

(gave it a quick test and it looked good)

@rullzer rullzer mentioned this pull request Mar 27, 2019
9 tasks
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rullzer rullzer force-pushed the bugfix/14639/theming branch from f396ec1 to 3860373 Compare March 28, 2019 07:02
@rullzer rullzer merged commit 76b22bd into master Mar 28, 2019
@rullzer rullzer deleted the bugfix/14639/theming branch March 28, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants