Skip to content

Fix various theming issues on bright colors #14885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 1 commit into from
Mar 28, 2019
Merged

Fix various theming issues on bright colors #14885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions apps/theming/css/theming.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ $invert: luma($color-primary) > 0.6;
a,
label,
p,
#alternative-logins legend {
#alternative-logins legend,
.lost-password-container #lost-password {
color: $color-primary-text;
}
input[type='checkbox'].checkbox--white + label:before {
Expand Down Expand Up @@ -175,8 +176,26 @@ input.primary,
}

@if ($invert) {
#body-login #submit-wrapper .icon-confirm-white {
background-image: url('../../../core/img/actions/confirm.svg');
#body-login {
.body-login-container {
background-color: $color-main-background;
}
#submit-wrapper .icon-confirm-white {
background-image: url('../../../core/img/actions/confirm.svg');
}
.body-login-container {
h2 {
color: $color-main-text;
}
.icon-search.icon-white {
// CSS variable is not used here since it is on the public page layout,
// where the dark theme doesn't apply at the moment
background-image: url('../../../core/img/actions/search.svg');
}
}
}
#body-public #header .icon-more-white {
background-image: var(--icon-more-000);
}
}

Expand Down
2 changes: 1 addition & 1 deletion core/css/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ nav[role='navigation'] {
text-overflow: initial;
width: auto;
overflow: hidden;
background-color: var(--color-primary-element);
background-color: var(--color-primary);
padding: 0 5px;
z-index: 2;
}
Expand Down