Skip to content

dont use part files for dav writes when the target folder doesn't have create permissions #15769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 2 commits into from
Jul 3, 2019
Merged

dont use part files for dav writes when the target folder doesn't have create permissions #15769

MorrisJobke merged 2 commits into from
Jul 3, 2019

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented May 28, 2019

Signed-off-by: Robin Appelman [email protected]

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 28, 2019
@icewind1991 icewind1991 added this to the Nextcloud 17 milestone May 28, 2019
@icewind1991
Copy link
Member Author

icewind1991 commented May 28, 2019

/backport to stable16

@icewind1991
Copy link
Member Author

icewind1991 commented May 28, 2019

/backport to stable15

@icewind1991 icewind1991 requested a review from skjnldsv June 13, 2019 14:32
@skjnldsv
Copy link
Member

skjnldsv commented Jun 13, 2019

@icewind1991 is there an existing issue this pr fixes? :)
Code looks good to me!

@icewind1991 icewind1991 force-pushed the part-file-non-creatable branch from e6620dd to 2cbd040 Compare June 13, 2019 15:04
@icewind1991
Copy link
Member Author

icewind1991 commented Jun 13, 2019

This issue came from a customer originally, I've added a test case for the issue

skjnldsv
skjnldsv approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Make sense!

@icewind1991 icewind1991 mentioned this pull request Jun 17, 2019
Closed
MorrisJobke
MorrisJobke approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke
Copy link
Member

MorrisJobke commented Jul 3, 2019

PHPUnit tests for comments failed. Thus I rebased this to fetch potential fixes.

@MorrisJobke MorrisJobke force-pushed the part-file-non-creatable branch from 2cbd040 to 3b6df74 Compare July 3, 2019 14:36
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 3, 2019
@MorrisJobke MorrisJobke merged commit 18b673e into master Jul 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the part-file-non-creatable branch July 3, 2019 21:30
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 3, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 3, 2019

backport to stable16 in #16223

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 3, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 3, 2019

backport to stable15 in #16224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: dav

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @skjnldsv @MorrisJobke