-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Properly catch password policy hint for personal page password changes #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer to be a potential reviewer. |
Member
Author
Member
|
please backport 👍 |
Signed-off-by: Morris Jobke <[email protected]>
Member
Author
c066033 to
c84dc6a
Compare
Member
|
Works 👍 |
Member
|
Awesome. 👍 |
Current coverage is 55.94% (diff: 31.57%)@@ master #1634 diff @@
==========================================
Files 1070 1070
Lines 60817 60859 +42
Methods 6838 6841 +3
Messages 0 0
Branches 0 0
==========================================
+ Hits 34022 34049 +27
- Misses 26795 26810 +15
Partials 0 0
|
nickvergessen
approved these changes
Oct 6, 2016
Member
Author
|
Tested with stable9 and stable10 and there it works fine. This was a regression due to #868 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abcwith password policy app enabled causes 503 and the password change text stays forever with no user feedback@karlitschek I would like to backport this to stable9 and stable10
cc @LukasReschke @nickvergessen @rullzer @schiessle @ChristophWurst