Skip to content

Conversation

@MorrisJobke
Copy link
Member

  • before: changing password to abc with password policy app enabled causes 503 and the password change text stays forever with no user feedback
  • with this: the proper hint message is shown

@karlitschek I would like to backport this to stable9 and stable10

cc @LukasReschke @nickvergessen @rullzer @schiessle @ChristophWurst

@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Oct 6, 2016
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer to be a potential reviewer.

@MorrisJobke
Copy link
Member Author

@karlitschek
Copy link
Member

please backport 👍

@MorrisJobke
Copy link
Member Author

@MorrisJobke MorrisJobke force-pushed the fix-password-policy-hint branch from c066033 to c84dc6a Compare October 6, 2016 08:55
@nickvergessen
Copy link
Member

Works 👍

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 6, 2016
@raghunayyar
Copy link
Member

Awesome. 👍

@codecov-io
Copy link

Current coverage is 55.94% (diff: 31.57%)

Merging #1634 into master will increase coverage by <.01%

@@             master      #1634   diff @@
==========================================
  Files          1070       1070          
  Lines         60817      60859    +42   
  Methods        6838       6841     +3   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          34022      34049    +27   
- Misses        26795      26810    +15   
  Partials          0          0          

Sunburst

Diff Coverage File Path
••• 31% settings/Controller/ChangePasswordController.php

Powered by Codecov. Last update ea9b1cc...c84dc6a

@nickvergessen nickvergessen merged commit 4873f08 into master Oct 6, 2016
@nickvergessen nickvergessen deleted the fix-password-policy-hint branch October 6, 2016 11:27
@MorrisJobke
Copy link
Member Author

Tested with stable9 and stable10 and there it works fine. This was a regression due to #868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants