Make ChangePassword a real Controller #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Kondou-ger, @schiessle and @LukasReschke to be potential reviewers |
| /** @var IAppManager */ | ||
| private $appManager; | ||
|
|
||
| public function __construct($appName, |
Member
|
Mind adding some tests for the stuff that's testable? (e.g. changePersonalPassword) |
rullzer
force-pushed
the
changepasswordcontroller
branch
from
f17928e to
5c7b188
Compare
Member
Author
|
Added some tests |
Member
|
LGTM |
| ], | ||
| ]); | ||
| } | ||
| } No newline at end of file |
Member
|
Changing still works as user, admin and subadmin 👍 |
Member
Please rebase while fixing the typo from above |
* Still no full DI because of encryption fu * Remove old "Controller"
nickvergessen
added
4. to release
rullzer
force-pushed
the
changepasswordcontroller
branch
from
5c7b188 to
789082e
Compare
nickvergessen
added
2. developing
Member
Author
|
And rebased |
nickvergessen
added
4. to release
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
Make ChangePassword a real Controller
Member
|
There was a regression: #1634 fixed it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less depreacted calls 🎉
This will get us a step closer to properly changepassword stuff.
CC: @LukasReschke @nickvergessen @MorrisJobke @icewind1991