Nested recursion breaking max nested level for parent comment calculation #16523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Member
Author
|
/backport to stable16 |
4 tasks
blizzz
approved these changes
Jul 24, 2019
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
The else is unnecessary. Why would this prevent an infinite loop however?
delete-merged-branch
bot
deleted the
bugfix/noid/nested-recursion-breaking-max-nested-level-for-parent-comment
branch
|
backport to stable16 in #16524 |
Member
Not the else, but the change from |
Member
Gosh, and i doublechecked that :-/ more ☕ needed. makes sense anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug had no effect so far because the comments app does not allow replying.
However the integration tests I'm writing for nextcloud/spreed#2000 failed with the following error, when replying to a message which was already a reply: