Skip to content

Nested recursion breaking max nested level for parent comment calculation #16523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 2 commits into from
Jul 24, 2019
Merged

Nested recursion breaking max nested level for parent comment calculation #16523

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b33416
Get the topmost parent for the parent instead of doing endless recursion
nickvergessen Jul 24, 2019
7d3a349
PHPStorm code cleanup
nickvergessen Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Get the topmost parent for the parent instead of doing endless recursion 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Jul 24, 2019
commit 3b334169a89c3aa0ef9b6e173a3f9bc8ad2fe0cb
2 changes: 1 addition & 1 deletion lib/private/Comments/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ protected function determineTopmostParentId($id) {
if ($comment->getParentId() === '0') {
return $comment->getId();
} else {
return $this->determineTopmostParentId($comment->getId());
return $this->determineTopmostParentId($comment->getParentId());
}
}

Expand Down