Fix/xss/on favorite file #16599
Merged
Fix/xss/on favorite file #16599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Fichtelmann <[email protected]>
Signed-off-by: Max Fichtelmann <[email protected]>
MaxFichtelmann
force-pushed
the
fix/xss/on-favorite-file
branch
from
dc63597 to
4977f23
Compare
rullzer
reviewed
Jul 30, 2019
juliusknorr
approved these changes
Jul 30, 2019
Member
|
Failures unrelated. |
juliusknorr
added
4. to release
Member
|
/backport to stable16 |
Member
|
/backport to stable15 |
Member
|
/backport to stable14 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
backport to stable16 in #16610 |
|
backport to stable15 in #16611 |
|
backport to stable14 in #16612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an XSS vulnerability with low availability in
files/js/tagsplugin.js.Additionally this PR addresses a potential XSS in
jscolor.js- I did not find a call path that could be exploited, but using innerHTML without sanitizing its input is unnecessarily dangerous.