Skip to content

Fix/xss/on favorite file #16599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Jul 30, 2019
Merged

Fix/xss/on favorite file #16599

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d29636
fix XSS when adding a file with a malicious name to favorites
MaxFichtelmann Jul 29, 2019
4977f23
prevent potential XSS via unchecked use innerHTML
MaxFichtelmann Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
prevent potential XSS via unchecked use innerHTML 
Signed-off-by: Max Fichtelmann <[email protected]>
  • Loading branch information
@MaxFichtelmann
MaxFichtelmann committed Jul 29, 2019
commit 4977f235f60a4ae4257f79b7d96d3cf109850072
2 changes: 1 addition & 1 deletion apps/theming/js/3rdparty/jscolor/jscolor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,7 +1100,7 @@ var jsc = {
if (jsc.isElementType(this.valueElement, 'input')) {
this.valueElement.value = value;
} else {
this.valueElement.innerHTML = value;
this.valueElement.innerHTML = _.escape(value);
}
}
if (!(flags & jsc.leaveStyle)) {
Expand Down