[oc] Register commands in info.xml #1705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @schiessle and @LukasReschke to be potential reviewers. |
nickvergessen
requested changes
Oct 11, 2016
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Please add those to be tested with https://github.com/nextcloud/server/blob/master/tests/lib/InfoXmlTest.php
Current coverage is 56.64% (diff: 31.57%)@@ master #1705 diff @@
==========================================
Files 1070 1065 -5
Lines 60432 60409 -23
Methods 6817 6818 +1
Messages 0 0
Branches 0 0
==========================================
+ Hits 34087 34217 +130
+ Misses 26345 26192 -153
Partials 0 0
|
* Use DI to load console commands from the apps - class name to be defined in the info.xml * Load commands from info.xml * Fix unit test * Allow Di magic for IMountManager Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
us_register-commands-in-info.xml
branch
from
ec7d7cb to
7eba1d8
Compare
Member
Author
|
Fixed |
Member
|
Tested and works 👍 |
MorrisJobke
approved these changes
Oct 11, 2016
nickvergessen
approved these changes
Oct 11, 2016
Member
|
👍 |
nickvergessen
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From owncloud/core#26248
CC: @nickvergessen @MorrisJobke @LukasReschke @icewind1991