Skip to content

Conversation

@DeepDiver1975
Copy link
Member

Description

Console commands can now be loaded from the info xml using DI magic

Motivation and Context

Less code - easier maintenance

How Has This Been Tested?

See if all the commands are still loaded in ./occ list - some have been executed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Sep 29, 2016
@mention-bot
Copy link

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @LukasReschke, @nickvergessen and @DeepDiver1975 to be potential reviewers

@butonic
Copy link
Member

butonic commented Sep 29, 2016

www-data@asylum:/var/www/oc/core$ php occ
PHP Fatal error:  Class 'OCA\Files_Versions\Hooks' not found in /home/jfd/www/core/apps/files_versions/appinfo/app.php on line 26
PHP Stack trace:
PHP   1. {main}() /home/jfd/www/core/occ:0
PHP   2. require_once() /home/jfd/www/core/occ:11
PHP   3. OC\Console\Application->loadCommands() /home/jfd/www/core/console.php:93
PHP   4. OC_App::loadApps() /home/jfd/www/core/lib/private/Console/Application.php:96
PHP   5. OC_App::loadApp() /home/jfd/www/core/lib/private/legacy/app.php:121
PHP   6. OC_App::requireAppFile() /home/jfd/www/core/lib/private/legacy/app.php:151
PHP   7. require_once() /home/jfd/www/core/lib/private/legacy/app.php:188

@DeepDiver1975 DeepDiver1975 force-pushed the register-commands-in-info.xml branch from 8167e87 to 2629416 Compare September 29, 2016 14:10
@butonic
Copy link
Member

butonic commented Sep 29, 2016

👍 diff of occ output pre post merg is the same, commands still execute

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants