Skip to content

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 28, 2019

backport of #15557
cc @rbuehlma @noelmartinon

@skjnldsv
Copy link
Member

skjnldsv commented Sep 28, 2019

@rullzer Handlebar have issues because the script uses npm i handlebar -g which install the latest, but our package requires the same as what is in the node_modules I think.

We should put the script in the package.json so we can use the same installed version :)

"message": "Error: Template was precompiled with a newer version of Handlebars
than the current runtime. Please update your runtime to a newer version
(>= 4.3.0).\nat core/js/dist/main.js:299:0"

@juliusknorr juliusknorr force-pushed the backport/15557/stable17 branch from c0aa5a5 to 9a0acbb Compare October 4, 2019 14:43
@juliusknorr
Copy link
Member

Rebased to include #17348

@rullzer
Copy link
Member

rullzer commented Oct 8, 2019

/compile amend /

@skjnldsv
Copy link
Member

skjnldsv commented Oct 8, 2019

One more issue with the infamouse npm i / npm ci :(

@rullzer rullzer force-pushed the backport/15557/stable17 branch from 9a0acbb to e6cec45 Compare October 22, 2019 18:05
@rullzer
Copy link
Member

rullzer commented Oct 22, 2019

/compile amend /

@rullzer rullzer merged commit 6c64af1 into stable17 Oct 22, 2019
@rullzer rullzer deleted the backport/15557/stable17 branch October 22, 2019 20:30
@rullzer rullzer mentioned this pull request Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants