Skip to content

[stable17] Use handlebars from node_modules (on CI) #17348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Oct 1, 2019
Merged

[stable17] Use handlebars from node_modules (on CI) #17348

rullzer merged 1 commit into from
Oct 1, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 1, 2019 •
edited by ChristophWurst
Loading

No description provided.

@skjnldsv skjnldsv mentioned this pull request Oct 1, 2019
Merged
@rullzer rullzer added this to the Nextcloud 17.0.1 milestone Oct 1, 2019
@ChristophWurst ChristophWurst changed the title Use handlebars from node_modules (on CI) [stable17] Use handlebars from node_modules (on CI) Oct 1, 2019
@rullzer
Copy link
Member

rullzer commented Oct 1, 2019

https://drone.nextcloud.com/nextcloud/server/21998/4/3 ci says no

@skjnldsv skjnldsv force-pushed the backport/stable17fix/hbs-compile-script branch from 5d98f3f to fc4b666 Compare October 1, 2019 07:17
ChristophWurst
ChristophWurst reviewed Oct 1, 2019
View reviewed changes
@ChristophWurst
Copy link
Member

ChristophWurst commented Oct 1, 2019

https://drone.nextcloud.com/nextcloud/server/21998/4/3 ci says no

@ChristophWurst says no. This build is from another PR. The original commit actually passed the Handlebars check :)

@skjnldsv skjnldsv force-pushed the backport/stable17fix/hbs-compile-script branch from fc4b666 to 99bbc17 Compare October 1, 2019 08:03
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 1, 2019

tests passes

@skjnldsv skjnldsv force-pushed the backport/stable17fix/hbs-compile-script branch from 99bbc17 to 5d98f3f Compare October 1, 2019 08:49
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 1, 2019

Reset back to first backport

@rullzer rullzer merged commit 95ea467 into stable17 Oct 1, 2019
@rullzer rullzer deleted the backport/stable17fix/hbs-compile-script branch October 1, 2019 09:59
@juliusknorr juliusknorr mentioned this pull request Oct 4, 2019
Merged
@rullzer rullzer mentioned this pull request Oct 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug technical debt

Projects

None yet

Milestone

Nextcloud 17.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @rullzer @ChristophWurst