Don't call basename on null #17359
Merged
Don't call basename on null #17359
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
bug
3. to review
kesselb
approved these changes
Oct 1, 2019
rullzer
approved these changes
Oct 1, 2019
kesselb
added
4. to release
Member
|
/backport to stable16 |
Member
|
/backport to stable15 |
|
backport to stable16 in #17441 |
|
backport to stable15 in #17442 |
Member
|
/backport to stable17 |
|
backport to stable17 in #17444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to 2f5eac1 it just fixes the result of the broken jailedpath call from b5f407e
Never the less I would do this PR now and do a quick backport so its not causing issues anymore until a final solution has been found.