Skip to content

Don't call basename on null #17359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 1 commit into from
Oct 4, 2019
Merged

Don't call basename on null #17359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't call basename on null 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Oct 1, 2019
commit 0f3de7828eb592eb2a8c5be11dadb61499f9e159
2 changes: 1 addition & 1 deletion apps/workflowengine/lib/Check/FileName.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function __construct(IL10N $l, IRequest $request) {
* @return string
*/
protected function getActualValue(): string {
return basename($this->path);
return $this->path === null ? '' : basename($this->path);
}

/**
Expand Down