Fix master testing and update eslint-config #17367

skjnldsv · 2019-10-02T09:07:50Z

After #17263

ChristophWurst

🙈

skjnldsv · 2019-10-02T09:09:12Z

I never seen a pr so fast approved! 😱 🚀

skjnldsv · 2019-10-02T09:16:55Z

/compile amend /

skjnldsv · 2019-10-02T09:17:18Z

Weird

Changes not staged for commit:
4728 | (use "git add <file>..." to update what will be committed)
4729 | (use "git checkout -- <file>..." to discard changes in working directory)
4730 |  
4731 | modified: apps/workflowengine/js/workflowengine.js.map
4732

skjnldsv · 2019-10-02T10:33:51Z

/compile amend /apps/workflowengine/js/

skjnldsv · 2019-10-02T10:38:41Z

Ah, now I get it :)
We should split the tests between two: compiling and git diff

skjnldsv · 2019-10-02T11:59:34Z

/compile amend /

skjnldsv · 2019-10-02T12:49:00Z

@nextcloud/javascript I need help here
https://drone.nextcloud.com/nextcloud/server/22087/2/3

I don't understand!

modified: apps/workflowengine/js/workflowengine.js.map

ChristophWurst · 2019-10-02T12:54:18Z

hold my php

ChristophWurst · 2019-10-02T12:56:59Z

should be fine now

skjnldsv · 2019-10-02T12:57:23Z

should be fine now

any explanations?

ChristophWurst · 2019-10-02T12:58:15Z

any explanations?

I ran

npm i

and then

npm run build

and the file in question was updated. So I amended.

skjnldsv · 2019-10-02T12:59:02Z

and the file in question was updated. So I amended.

yes, I did that 10 times!
Every time the file change. Also, I used the compile bot just before, so it should have done the exact same thing than you did :)

ChristophWurst · 2019-10-02T12:59:40Z

Then let's see who's version wins 🍿

skjnldsv · 2019-10-02T13:24:32Z

Then let's see who's version wins

Ahahahaha
https://drone.nextcloud.com/nextcloud/server/22089/2/3

told you 😉

skjnldsv · 2019-10-03T08:44:52Z

🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀

rullzer · 2019-10-03T09:36:50Z

apps/workflowengine/templates/settings.php

 *
 */
+use OCA\WorkflowEngine\AppInfo\Application;
+style(Application::APP_ID, 'multiselect');


So... I'm happy it works now. But it still feels hacky. Including the CSS into the bundle is much nicer IMO (as it saves requests). But lets debug that later.

Let's ping @juliushaertl 🙈

Added it to the list to fix in #12790

skjnldsv · 2019-10-03T09:42:34Z

@danxuliu there are some acceptance tests failures.
No idea if they were here before or not. Could you check please?

--- Failed scenarios:

    /nextcloud/tests/acceptance/features/app-comments.feature:171
    /nextcloud/tests/acceptance/features/app-comments.feature:195
    /nextcloud/tests/acceptance/features/app-files-sharing-link.feature:101
    /nextcloud/tests/acceptance/features/app-files-sharing.feature:131
    /nextcloud/tests/acceptance/features/app-files-sharing.feature:150
    /nextcloud/tests/acceptance/features/app-files-sharing.feature:170
    /nextcloud/tests/acceptance/features/app-files-sharing.feature:196
    /nextcloud/tests/acceptance/features/app-files-sharing.feature:245
    /nextcloud/tests/acceptance/features/app-files-tags.feature:31
    /nextcloud/tests/acceptance/features/app-files.feature:22
    /nextcloud/tests/acceptance/features/app-files.feature:108

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

skjnldsv · 2019-10-04T05:05:10Z

@danxuliu there are some acceptance tests failures.
No idea if they were here before or not. Could you check please?

SHould be fixed now :)

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>

skjnldsv · 2019-10-04T05:49:39Z

Also fixed the acceptance-app-files-tags ^^
It was failing since #16682 (2 months)

ChristophWurst · 2019-10-04T06:28:42Z

I would appreciate if we could have a second person review & approve the changes that happen after the reviews :)

skjnldsv · 2019-10-04T06:29:31Z

@ChristophWurst but there is 2 reviews 🤔

danxuliu · 2019-10-04T13:45:25Z

@danxuliu there are some acceptance tests failures.
No idea if they were here before or not. Could you check please?

They came from #17263. And I missed the mention and this pull request; I found the acceptance tests failures in another one. So after manually bisecting the commit (please, next time remove the ending semicolon in one commit, add the missing spaces in other, fix the documentation parameters in other... ;-) ) I finally found that the issue was caused by the destructuring assignment. And when I was happily going to open the pull request to fix it... then I saw that you already fixed it here! I want to cry :-P

Jokes aside, I would have expected Babel to transpile the destructuring assignment to something that older browsers could handle (as I guess that the same issue would happen in Internet Explorer 11). Maybe some rule or plugin is missing?

skjnldsv · 2019-10-04T13:49:08Z

I want to cry :-P

/me pat @danxuliu in the back 😁

Yeah, it's a bit weird! I reverted back the fix of the detructuring assignment and ignoroed eslint warning as this is a weird hack for old firefox entries. We shouldn't mess with this too much :)

skjnldsv requested review from ChristophWurst, georgehrke, juliusknorr, nickvergessen and rullzer October 2, 2019 09:07

skjnldsv self-assigned this Oct 2, 2019

skjnldsv added 3. to review Waiting for reviews bug feature: dependencies labels Oct 2, 2019

skjnldsv added this to the Nextcloud 18 milestone Oct 2, 2019

ChristophWurst approved these changes Oct 2, 2019

View reviewed changes

nickvergessen approved these changes Oct 2, 2019

View reviewed changes

ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 2, 2019

skjnldsv force-pushed the fix/master-eslint-tests branch from 91e7a3a to 3a00b3a Compare October 2, 2019 09:42

npmbuildbot-nextcloud bot force-pushed the fix/master-eslint-tests branch from 3a00b3a to 515e9ef Compare October 2, 2019 10:35

skjnldsv force-pushed the fix/master-eslint-tests branch from 515e9ef to e90029b Compare October 2, 2019 10:38

skjnldsv force-pushed the fix/master-eslint-tests branch from 3849582 to 4376715 Compare October 2, 2019 11:24

npmbuildbot-nextcloud bot force-pushed the fix/master-eslint-tests branch from 4376715 to 9afbacd Compare October 2, 2019 12:01

ChristophWurst force-pushed the fix/master-eslint-tests branch from 9afbacd to 4a3078f Compare October 2, 2019 12:56

skjnldsv force-pushed the fix/master-eslint-tests branch 3 times, most recently from 78a9698 to 24e47d4 Compare October 3, 2019 08:36

rullzer reviewed Oct 3, 2019

View reviewed changes

This was referenced Oct 3, 2019

Use the external initial state implementation #17390

Merged

Use @nextcloud/paths and deprecate OC helpers #17392

Merged

skjnldsv added 2 commits October 4, 2019 06:44

Fix master testing and update eslint-config

c2c7c27

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Split drone webpack tests

972279d

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

skjnldsv force-pushed the fix/master-eslint-tests branch from 24e47d4 to 972279d Compare October 4, 2019 05:04

Fix tag acceptance tests after #16682

4293ede

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>

skjnldsv merged commit 6d819e2 into master Oct 4, 2019

skjnldsv deleted the fix/master-eslint-tests branch October 4, 2019 06:18

blizzz mentioned this pull request Oct 4, 2019

Workflow Improvements #12790

Open

16 tasks

Uh oh!

Fix master testing and update eslint-config #17367

Fix master testing and update eslint-config #17367

Uh oh!

Conversation

skjnldsv commented Oct 2, 2019

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

skjnldsv commented Oct 2, 2019

Uh oh!

skjnldsv commented Oct 2, 2019

Uh oh!

skjnldsv commented Oct 2, 2019

Uh oh!

skjnldsv commented Oct 2, 2019

Uh oh!

skjnldsv commented Oct 2, 2019

Uh oh!

skjnldsv commented Oct 2, 2019

Uh oh!

skjnldsv commented Oct 2, 2019

Uh oh!

ChristophWurst commented Oct 2, 2019

Uh oh!

ChristophWurst commented Oct 2, 2019

Uh oh!

skjnldsv commented Oct 2, 2019

Uh oh!

ChristophWurst commented Oct 2, 2019

Uh oh!

skjnldsv commented Oct 2, 2019

Uh oh!

ChristophWurst commented Oct 2, 2019

Uh oh!

skjnldsv commented Oct 2, 2019

Uh oh!

skjnldsv commented Oct 3, 2019

Uh oh!

rullzer Oct 3, 2019

Choose a reason for hiding this comment

Uh oh!

skjnldsv Oct 3, 2019

Choose a reason for hiding this comment

Uh oh!

juliusknorr Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

skjnldsv commented Oct 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skjnldsv commented Oct 4, 2019

Uh oh!

skjnldsv commented Oct 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChristophWurst commented Oct 4, 2019

Uh oh!

skjnldsv commented Oct 4, 2019

Uh oh!

danxuliu commented Oct 4, 2019

Uh oh!

skjnldsv commented Oct 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

skjnldsv commented Oct 3, 2019 •

edited

Loading

skjnldsv commented Oct 4, 2019 •

edited

Loading