Use the external initial state implementation #17390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
🤔 🤔 🤔 |
rullzer
force-pushed
the
refactor/external-initial-state-impl
branch
from
8b71121 to
6d18749
Compare
Member
|
Rebased and fixed the eslint warnings... |
Member
still a lot |
rullzer
approved these changes
Oct 4, 2019
skjnldsv
requested changes
Oct 4, 2019
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Let's figure out what the heck is going on before merging :)
ChristophWurst
force-pushed
the
refactor/external-initial-state-impl
branch
2 times, most recently
from
8f8e352 to
ab0845b
Compare
Member
Author
@skjnldsv better? |
Member
|
Tests will not pass, right? |
Member
Author
They also passed at #17392 (comment), where I think you've used "npm ci" because master build is not reproducible for me right now. |
Member
|
Failed ;) |
Signed-off-by: Christoph Wurst <[email protected]>
rullzer
force-pushed
the
refactor/external-initial-state-impl
branch
from
ab0845b to
c2e8821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref nextcloud-libraries/nextcloud-initial-state#22