Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #17578

@rullzer rullzer added the 4. to release Ready to be released and/or waiting for tests to finish label Oct 22, 2019
@rullzer rullzer merged commit 9aa7f4b into stable15 Oct 22, 2019
@rullzer rullzer deleted the backport/17578/stable15 branch October 22, 2019 18:18
@rullzer rullzer mentioned this pull request Oct 28, 2019
@Kieltux
Copy link

Kieltux commented Nov 10, 2019

In 15.0.13 /lib/public/AppFramework/Http/TemplateResponse.php is missing the two following constants:
const EVENT_LOAD_ADDITIONAL_SCRIPTS = self::class . '::loadAdditionalScripts'; const EVENT_LOAD_ADDITIONAL_SCRIPTS_LOGGEDIN = self::class . '::loadAdditionalScriptsLoggedIn';

@kesselb
Copy link
Contributor

kesselb commented Nov 10, 2019

Yes. LoadAdditionalScripts is Nextcloud 16+. So we need a different way for Nextcloud 15.

cc @juliushaertl @rullzer

@rullzer
Copy link
Member

rullzer commented Nov 11, 2019

Ah mmm I tought it was 15...
@juliushaertl please check the files app and just fire that event I guess...

@blizzz
Copy link
Member

blizzz commented Nov 21, 2019

saml tests for 15 also fail because of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants