Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Jan 29, 2019

Fixes #13662

This will fire of an event after a Template Response has been returned.
There is an event for the generic loading and one when logged in. So
apps can chose to load only on loged in pages.

This is a more generic approach than the files app event. As some things
we might want to load on other pages as well besides the files app.

Todo:

Signed-off-by: Roeland Jago Douma [email protected]

@rullzer rullzer added enhancement 3. to review Waiting for reviews labels Jan 29, 2019
@rullzer rullzer added this to the Nextcloud 16 milestone Jan 29, 2019
@rullzer rullzer requested a review from juliusknorr January 29, 2019 20:26
@rullzer rullzer changed the title Emit to load additionalscripts Emit event to load additionalscripts Jan 29, 2019
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and clean 👍

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@rullzer
Copy link
Member Author

rullzer commented Jan 31, 2019

Then let me add some tests later today for the middleware. And then this can get in :)

Fixes #13662

This will fire of an event after a Template Response has been returned.
There is an event for the generic loading and one when logged in. So
apps can chose to load only on loged in pages.

This is a more generic approach than the files app event. As some things
we might want to load on other pages as well besides the files app.

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer force-pushed the enh/13662/events_to_load_additional_scripts branch from 9450367 to d182037 Compare January 31, 2019 11:11
@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 31, 2019
@rullzer rullzer merged commit 5c4ed02 into master Jan 31, 2019
@rullzer rullzer deleted the enh/13662/events_to_load_additional_scripts branch January 31, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants