Drop php 7.1 support

[rullzer]

18 will be relased when php7.1 is EOL already. So lets kill it!

Blocked by:

• Add php7.4 support #18064

Signed-off-by: Roeland Jago Douma [email protected]

[rullzer]

@danxuliu I guess all the tests are converted now away from 7.1 right?

[nickvergessen]

Just for the record, this will require adjustments in all apps. But there is a script for that 😎 Hopefully I can do that tonight or sometime before monday when everyone tries to push to any app and it just breaks.

Is 7.4 already stable enough to be added before?

If so, it would be nice to:

1. Merge a PR that allows 7.4 in server
2. Adjust all apps (remove 7.1 and add 7.4)
3. Merge the removal of 7.1

Otherwise all PRs I have to create will be red CI

[rullzer]

Just for the record, this will require adjustments in all apps. But there is a script for that sunglasses Hopefully I can do that tonight or sometime before monday when everyone tries to push to any app and it just breaks.

Is 7.4 already stable enough to be added before?

7.4 PR is on its way. But they are at rc6 so yeah good enough to use in app (but server doesn't run on it yet).

We could of course just wait merging this till your script ran

[rullzer]

Ok lets wait for #18064 to be done then

[danxuliu]

I guess all the tests are converted now away from 7.1 right?

In theory, yes. Some integration tests failed, although it seems that they failed already in #18063.

[juliusknorr]

Pushed a new tag for integration-php7.3 that needs to be bumped once available on docker hub.

[rullzer]

Pushed a new tag for integration-php7.3 that needs to be bumped once available on docker hub.

Sure but we can also do that separatly. The changes were not part of this PR so dropping 7.1 here is not related to that.