Skip to content

Drop php 7.1 support #18062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Nov 29, 2019
Merged

Drop php 7.1 support #18062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3021491
Drop php 7.1 support
rullzer Nov 21, 2019
3cda67c
Fix integration
rullzer Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/integration/run-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ cd "$(dirname $0)"

# "--image XXX" option can be provided to set the Docker image to use to run
# the integration tests (one of the "nextcloudci/phpX.Y:phpX.Y-Z" images).
NEXTCLOUD_LOCAL_IMAGE="nextcloudci/php7.1:php7.1-15"
NEXTCLOUD_LOCAL_IMAGE="nextcloudci/php7.3:php7.3-5"
if [ "$1" = "--image" ]; then
NEXTCLOUD_LOCAL_IMAGE=$2

Expand Down
6 changes: 3 additions & 3 deletions lib/versioncheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?php

// Show warning if a PHP version below 7.1 is used,
if (version_compare(PHP_VERSION, '7.1') === -1) {
// Show warning if a PHP version below 7.2 is used,
if (version_compare(PHP_VERSION, '7.2') === -1) {
http_response_code(500);
echo 'This version of Nextcloud requires at least PHP 7.1<br/>';
echo 'This version of Nextcloud requires at least PHP 7.2<br/>';
echo 'You are currently running ' . PHP_VERSION . '. Please update your PHP version.';
exit(-1);
}
Expand Down