Skip to content

Allow apps to have their own manifest files #18584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gko wants to merge 4 commits into from
Closed

Allow apps to have their own manifest files #18584

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2442d78
Allow apps to have their own manifest files
gko Dec 27, 2019
d1a8af5
we need to keep add hash to manifest file if it exists
gko Dec 28, 2019
25c70e4
more generic solution
gko Dec 28, 2019
e8b8a0c
Revert "we need to keep add hash to manifest file if it exists"
gko Dec 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "we need to keep add hash to manifest file if it exists" 
This reverts commit d1a8af5.

Signed-off-by: Konstantin Gorodinskii <[email protected]>
  • Loading branch information
@gko
gko committed Dec 29, 2019
commit e8b8a0c0e59d9c524b76b981fb639efb0bcda86e
2 changes: 1 addition & 1 deletion apps/theming/lib/ThemingDefaults.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ public function replaceImagePath($app, $image) {
try {
$appPath = $this->appManager->getAppPath($app);
if (file_exists($appPath . '/img/manifest.json')) {
return $this->urlGenerator->linkTo($app, 'img/manifest.json') . '?v=' . $cacheBusterValue;
return false;
}
} catch (AppPathNotFoundException $e) {}
$route = $this->urlGenerator->linkToRoute('theming.Theming.getManifest');
Expand Down