Skip to content

Allow apps to have their own manifest files #18584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gko wants to merge 4 commits into from
Closed

Allow apps to have their own manifest files #18584

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2442d78
Allow apps to have their own manifest files
gko Dec 27, 2019
d1a8af5
we need to keep add hash to manifest file if it exists
gko Dec 28, 2019
25c70e4
more generic solution
gko Dec 28, 2019
e8b8a0c
Revert "we need to keep add hash to manifest file if it exists"
gko Dec 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/private/Setup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,9 @@ public static function updateHtaccess() {
$content .= "\n RewriteCond %{REQUEST_FILENAME} !\\.(css|js|svg|gif|png|html|ttf|woff2?|ico|jpg|jpeg|map)$";
$content .= "\n RewriteCond %{REQUEST_FILENAME} !core/img/favicon.ico$";
$content .= "\n RewriteCond %{REQUEST_FILENAME} !core/img/manifest.json$";
foreach (\OC::$APPSROOTS as ['url' => $url]) {
$content .= "\n RewriteCond %{REQUEST_FILENAME} !" . trim($url, '/') . "/[\w-_]+/img/manifest.json$";
Copy link
Contributor

@kesselb kesselb Dec 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could replace the foreach with a more generic RewriteCond. If someone is adding a new app_path he will probably not regenerate the htaccess. Such issues are hard to spot even if we document it somewhere. I'm not sure yet. Thats a obscure edge case of course 🤔

}
$content .= "\n RewriteCond %{REQUEST_FILENAME} !/remote.php";
$content .= "\n RewriteCond %{REQUEST_FILENAME} !/public.php";
$content .= "\n RewriteCond %{REQUEST_FILENAME} !/cron.php";
Expand Down