Skip to content

Fix jsunit tests #20470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Apr 14, 2020
Merged

Fix jsunit tests #20470

skjnldsv merged 1 commit into from
Apr 14, 2020

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Apr 14, 2020

JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago.

skjnldsv
skjnldsv approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@kesselb
Copy link
Contributor Author

kesselb commented Apr 14, 2020

Shit 🙈 ^2.0.1 is also matching 2.0.2 🤣 Probably the error is gone if you use a newer node version for running the tests. I'm not able to reproduce locally with Node 10.3.

@kesselb
Fix jsunit tests
0ccaec9 
JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago.

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the fix/noid/karma-coverage branch from ad322df to 0ccaec9 Compare April 14, 2020 09:55
MorrisJobke
MorrisJobke approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 14, 2020
@MorrisJobke MorrisJobke added this to the Nextcloud 19 milestone Apr 14, 2020
@skjnldsv skjnldsv merged commit a5c186b into master Apr 14, 2020
@skjnldsv skjnldsv deleted the fix/noid/karma-coverage branch April 14, 2020 12:35
@rullzer rullzer mentioned this pull request Apr 15, 2020
Merged
59 tasks
@kesselb
Copy link
Contributor Author

kesselb commented Apr 18, 2020

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 18, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Apr 18, 2020

backport to stable18 in #20548

@kesselb kesselb mentioned this pull request Apr 19, 2020
Merged
This was referenced Apr 23, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@danxuliu danxuliu Awaiting requested review from danxuliu

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: dependencies

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

4 participants

@kesselb @MorrisJobke @skjnldsv