[stable16] Fix jsunit tests #20621
Merged
[stable16] Fix jsunit tests #20621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago. Signed-off-by: Daniel Kesselberg <[email protected]>
skjnldsv
approved these changes
Apr 23, 2020
MorrisJobke
approved these changes
Apr 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20470
I have kept the
settings/js/apps.jsentry in tests/karma.config.js as it is a valid path in stable16 (although it does not seem to have any effect on the tests, though).The
build/package-lock.jsonwas also updated, although it is worth noting that it is ignored when the tests are run in Drone, asnextcloudci/jsunit:jsunit-5is still using npm 3.10.8 and back then there was no support yet for package-lock files (it was introduced in NPM 5 if I recall correctly).