Skip to content

Fix pagination of contacts search #21221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jun 15, 2020
Merged

Fix pagination of contacts search #21221

nickvergessen merged 1 commit into from
Jun 15, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 4, 2020

Follow up for #20720

@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Jun 4, 2020
This was referenced Jun 4, 2020
Merged
Merged
@tacruc
Copy link
Contributor

tacruc commented Jun 4, 2020

Are there not tests for this backend, which could be adapted?

@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 4, 2020

There are tests and they still work 😎

But yeah, I guess I could add a test with 5 users and use a limit and offset of 1 e.g.

@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 4, 2020

Tests added @tacruc

tacruc
tacruc approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@tacruc tacruc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickvergessen nickvergessen force-pushed the bugfix/20720/fix-pagination-of-contacts-search branch from 68a27e3 to fdd8c86 Compare June 10, 2020 07:39
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 10, 2020

Rebased and squashed

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 10, 2020
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 10, 2020

/backport to stable19

@nickvergessen nickvergessen merged commit 839f27b into master Jun 15, 2020
@nickvergessen nickvergessen deleted the bugfix/20720/fix-pagination-of-contacts-search branch June 15, 2020 06:46
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 15, 2020
Merged
@nickvergessen nickvergessen mentioned this pull request Jul 6, 2020
Closed
@blizzz blizzz mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacruc tacruc tacruc approved these changes

@J0WI J0WI J0WI approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: dav

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @tacruc @J0WI