Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Oct 14, 2020

backport of #18816, #20720 and #21221 required by #23423

juliusknorr and others added 3 commits October 14, 2020 14:02
@blizzz blizzz added bug 3. to review Waiting for reviews labels Oct 14, 2020
@blizzz blizzz added this to the Nextcloud 18.0.11 milestone Oct 14, 2020
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke
Copy link
Member

There was 1 failure:

  1. Test\User\DatabaseTest::testSearch
    Failed asserting that actual size 3 matches expected size 2.

/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:125

@blizzz Unrelated?

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 14, 2020
@blizzz
Copy link
Member Author

blizzz commented Oct 14, 2020

@MorrisJobke I'd say so, at least I cannot image what should cause it and it happens on sqlite only (wrong row, but still). Nevertheless, I let them rerun to be sure.

@faily-bot
Copy link

faily-bot bot commented Oct 14, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34150: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #118 ('folder', 23, 3)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:361

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGetSharedWithUserWithNode with data set #2 ('smb::whatever', 'files_trashbin/files/test.txt', 'files_trashbin/files/test2.txt')
Failed asserting that '66' matches expected 0.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1148

acceptance-header

  • failure block could not be found - most likely this run got canceled
Show full log
+ tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-header --selenium-server selenium:4444 allow-git-repository-modifications features/header.feature
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Warning from https://packagist.org: You are using an outdated version of Composer. Composer 2.0 is about to be released and the older 1.x releases will self-update directly to it once it is released. To avoid surprises update now to the latest 1.x version which will prompt you before self-updating to 2.x.
Updating dependencies (including require-dev)

                                                                                                                                                                                                         
  [Composer\Downloader\TransportException]                                                                                                                                                               
  The "http://packagist.org/p/vimeo/psalm%248d90f01a56dd6257eeed596ce850a074578ae81ccf7004e0a8aa91b1ed3e9d19.json" file could not be downloaded: failed to open stream: Cannot assign requested address  
                                                                                                                                                                                                         

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...

acceptance-login

  • failure block could not be found - most likely this run got canceled
Show full log
+ tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-login --selenium-server selenium:4444 allow-git-repository-modifications features/login.feature
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Warning from https://packagist.org: You are using an outdated version of Composer. Composer 2.0 is about to be released and the older 1.x releases will self-update directly to it once it is released. To avoid surprises update now to the latest 1.x version which will prompt you before self-updating to 2.x.
Updating dependencies (including require-dev)

                                                                                                                                                                                                           
  [Composer\Downloader\TransportException]                                                                                                                                                                 
  The "http://packagist.org/p/provider-2016%248ea57cba7a504dcd18fc1880d2ac2015f88f98eb67f947de5853f1a3684665ca.json" file could not be downloaded: failed to open stream: Cannot assign requested address  
                                                                                                                                                                                                           

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...

@MorrisJobke MorrisJobke merged commit 311cf82 into stable18 Oct 14, 2020
@MorrisJobke MorrisJobke deleted the backport/18816+20720+21221/stable18 branch October 14, 2020 19:24
@rullzer rullzer mentioned this pull request Nov 9, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants