Skip to content

Fix modal support for vue apps #21417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 5 commits into from
Jun 17, 2020
Merged

Fix modal support for vue apps #21417

nickvergessen merged 5 commits into from
Jun 17, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 15, 2020

  • Fixes missing modal background for vue apps #content vs .content
  • Makes confirmDestructive a modal by default
  • Makes the modal darkmode compatible (black overlaying black is not too useful, so I use the font color now)
Before After
Bildschirmfoto von 2020-06-15 17-00-36 Bildschirmfoto von 2020-06-15 17-00-25

@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Jun 15, 2020
@nickvergessen nickvergessen mentioned this pull request Jun 15, 2020
Merged
@nickvergessen nickvergessen requested a review from danxuliu June 15, 2020 15:05
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 15, 2020

/backport to stable19

@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 15, 2020

/backport to stable18

ChristophWurst
ChristophWurst approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

gary-kim
gary-kim approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

jancborchardt
jancborchardt approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

skjnldsv
skjnldsv reviewed Jun 16, 2020
View reviewed changes
skjnldsv
skjnldsv approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, otherwise good! 👍

jancborchardt
jancborchardt requested changes Jun 16, 2020
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call with the 0.8 instead of 0.2 overlay – looks much better than a bright backdrop.

@nickvergessen
Darker background for dark mode
eca3c9f 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 17, 2020
jancborchardt
jancborchardt approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! :)

@nickvergessen nickvergessen merged commit ee59029 into master Jun 17, 2020
@nickvergessen nickvergessen deleted the bugfix/noid/modal-support-for-vue-apps branch June 17, 2020 13:35
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jun 17, 2020

The backport to stable19 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jun 17, 2020

The backport to stable18 failed. Please do this backport manually.

This was referenced Jun 23, 2020
Merged
Merged
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 23, 2020

Backports done manually:
#21541
#21543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@gary-kim gary-kim gary-kim approved these changes

@rmanibus rmanibus Awaiting requested review from rmanibus

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: accessibility

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @jancborchardt @ChristophWurst @skjnldsv @gary-kim