"409 Conflict" on joining a second time in the same conversation #3591

nickvergessen · 2020-05-15T13:08:32Z

nickvergessen · 2020-05-29T08:47:40Z

This is part 1 of solving #3415

It asks the user whether they want to join a conversation when the previous session pinged in the last 40 seconds (or 60 when it was/is in a call). Reloading within the same tab will always force join automatically.

Part 2 is handling the previous session, in case the user picked the "force join" option. That will be handled in #3338

nickvergessen · 2020-05-29T08:49:01Z

Oh, missed to leave the old session on the signaling server in case of a force join

lib/Controller/RoomController.php

nickvergessen · 2020-06-15T15:05:30Z

Now works also acceptable while chatting with the HPB (with nextcloud/server#21417 applied):

Todo:

Check behaviour when in a call

nickvergessen · 2020-06-16T09:43:53Z

Remaining issue:

The "new" sessions UI shows as "isInCall" while the question is prompted and then toggles out of the call when clicking anything. I guess we should set the "isInCall" only when the current window/session joined the call.

nickvergessen · 2020-06-16T09:59:38Z

Ready to review 🎉

nickvergessen · 2020-06-19T10:06:19Z

/backport to stable19

danxuliu

There might be something broken in my setup, because the only thing that works for me is trying to join the same conversation in another tab as a user with the HPB but staying in the previous one. Everything else has some kind of issue.

With HPB:
- With a user:
  - Open the same conversation in another tab and choose Join here: the previous tab is redirected to Duplicate session, but the participant is shown as not connected in the new tab.
- With a guest:
  - Open the same conversation in another tab and choose Join here: the previous tab just stays in the conversation (although in the browser console it can be seen that is connected and disconnected from the external signaling server again and again).
  - Open the same conversation in another tab and choose Leave this page: the new tab is redirected to apps/spreed (which shows the login screen rather than the Duplicate session message)
Without HPB:
- With a user:
  - Open the same conversation in another tab and choose Join here: both the previous tab and the new tab are redirected to Duplicate session
  - Open the same conversation in another tab and choose Leave this page: the previous tab is redirected to Duplicate session (but only sometimes, other times it works)
- With a guest:
  - Open the same conversation in another tab and choose Join here: both the previous tab and the new tab are redirected to apps/spreed
  - Open the same conversation in another tab and choose Leave this page: the new tab is redirected to apps/spreed

Additionally, if a conversation is created and a call is immediately started in that conversation the UI will not change to the call view.

Signed-off-by: Joas Schilling <[email protected]>

Note: This uses the browsers sessionStorage not the browserStorage. As per https://stackoverflow.com/q/20325763 this is NOT shared between tabs. For us this is the solution we were looking for, as it allows us to identify if a user reloaded a conversation in the same tab, or entered it in another tab. Signed-off-by: Joas Schilling <[email protected]>

Signed-off-by: Joas Schilling <[email protected]>

404: now redirects to /not-found *: now retries after 10 seconds and shows an error and give up after 5 minutes recommending a reload Signed-off-by: Joas Schilling <[email protected]>

… user Signed-off-by: Joas Schilling <[email protected]>

Signed-off-by: Joas Schilling <[email protected]>

Otherwise there is no update of the computed and the call screen will not show up. Signed-off-by: Joas Schilling <[email protected]>

Signed-off-by: Joas Schilling <[email protected]>

But they were actually removed from the conversation. Signed-off-by: Joas Schilling <[email protected]>

…eady changed Signed-off-by: Joas Schilling <[email protected]>

Signed-off-by: Joas Schilling <[email protected]>

danxuliu

Tested and works 👍

Yay! :-D

nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels May 15, 2020

nickvergessen added this to the 💚 Next Major (20) milestone May 15, 2020

nickvergessen changed the title ~~Bugfix/3415/conflict on joining a second time~~ "409 Conflict" on joining a second time in the same conversation May 15, 2020

nickvergessen force-pushed the bugfix/3415/conflict-on-joining-a-second-time branch from 230c01f to 634b0f8 Compare May 29, 2020 08:42

nickvergessen marked this pull request as ready for review May 29, 2020 08:44

nickvergessen requested review from danxuliu and marcoambrosini May 29, 2020 08:44

nickvergessen added 2. developing 3. to review and removed 3. to review 2. developing labels May 29, 2020

nickvergessen mentioned this pull request May 29, 2020

Die gracefully when user joins again in another tab/device #3338

Closed

4 tasks

nickvergessen commented May 29, 2020

View reviewed changes

lib/Controller/RoomController.php Show resolved Hide resolved

nickvergessen added 2. developing and removed 3. to review labels Jun 8, 2020

nickvergessen force-pushed the bugfix/3415/conflict-on-joining-a-second-time branch from c5f6744 to a0aad3f Compare June 15, 2020 15:04

nickvergessen added 3. to review and removed 2. developing labels Jun 16, 2020

backportbot-nextcloud bot added the backport-request label Jun 19, 2020

nickvergessen self-assigned this Jun 22, 2020

danxuliu reviewed Jun 24, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

nickvergessen added 21 commits July 1, 2020 10:00

Optionally return 409 when trying to join a second time

f5198c0

Signed-off-by: Joas Schilling <[email protected]>

Also support guests to prevent breaking their sessions

5e6a21b

Signed-off-by: Joas Schilling <[email protected]>

Return session id, in call flag and last ping

d5c42d8

Signed-off-by: Joas Schilling <[email protected]>

Ask for confirmation to join in case of session conflict

6b36032

Signed-off-by: Joas Schilling <[email protected]>

Automatically force join if the session is "old"

cd81c6e

Signed-off-by: Joas Schilling <[email protected]>

Add documentation for the conflict handling

da78e4c

Signed-off-by: Joas Schilling <[email protected]>

Leave the room with the old session

5bce99b

Signed-off-by: Joas Schilling <[email protected]>

Further pass on the sessionId to leaveRoomAsParticipant

ee2632b

Signed-off-by: Joas Schilling <[email protected]>

Handle duplicated sessions more gracefully with the internal signaling

61134a0

Signed-off-by: Joas Schilling <[email protected]>

Better handle 404 error as well as all other undefined scenarios

dd48b52

404: now redirects to /not-found *: now retries after 10 seconds and shows an error and give up after 5 minutes recommending a reload Signed-off-by: Joas Schilling <[email protected]>

Show session conflict warning when a session joins again for your own…

9fc01a6

… user Signed-off-by: Joas Schilling <[email protected]>

Redirect to a plain page to avoid reconnections

9775215

Signed-off-by: Joas Schilling <[email protected]>

Send a signal to disconnect the old session before killing it

237d2f5

Signed-off-by: Joas Schilling <[email protected]>

Don't show call state when asking to kill the other session

5f83e23

Signed-off-by: Joas Schilling <[email protected]>

Trigger a vue event when SessionStorage "joined_conversation" changes

389d7b6

Otherwise there is no update of the computed and the call screen will not show up. Signed-off-by: Joas Schilling <[email protected]>

Don't kill the previous session when we navigate away

d54249f

Signed-off-by: Joas Schilling <[email protected]>

Handle the disinvite event properly when the session was kicked

eba73a3

Signed-off-by: Joas Schilling <[email protected]>

Add a hack to check if the dialog was closed via the X

0f2176b

Signed-off-by: Joas Schilling <[email protected]>

If the user has no participant anymore, it was not a conflict

1efead6

But they were actually removed from the conversation. Signed-off-by: Joas Schilling <[email protected]>

Fix mixin state also when the component is loaded after the state alr…

0c729f0

…eady changed Signed-off-by: Joas Schilling <[email protected]>

nickvergessen force-pushed the bugfix/3415/conflict-on-joining-a-second-time branch from 2a49040 to db24555 Compare July 1, 2020 08:00

Update the session and the call flag when force joining

e5c75cb

Signed-off-by: Joas Schilling <[email protected]>

nickvergessen force-pushed the bugfix/3415/conflict-on-joining-a-second-time branch from db24555 to e5c75cb Compare July 1, 2020 10:08

danxuliu approved these changes Jul 1, 2020

View reviewed changes

nickvergessen merged commit ce850e4 into master Jul 1, 2020

nickvergessen deleted the bugfix/3415/conflict-on-joining-a-second-time branch July 1, 2020 11:10

backportbot-nextcloud bot mentioned this pull request Jul 1, 2020

[stable19] "409 Conflict" on joining a second time in the same conversation #3866

Merged

backportbot-nextcloud bot removed the backport-request label Jul 1, 2020

parafin mentioned this pull request Jul 22, 2020

The same user can't join a room multiple times #1587

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

"409 Conflict" on joining a second time in the same conversation #3591

"409 Conflict" on joining a second time in the same conversation #3591

Uh oh!

nickvergessen commented May 15, 2020 •

edited

Loading

Uh oh!

nickvergessen commented May 29, 2020

Uh oh!

nickvergessen commented May 29, 2020

Uh oh!

Uh oh!

nickvergessen commented Jun 15, 2020 •

edited

Loading

Uh oh!

nickvergessen commented Jun 16, 2020 •

edited

Loading

Uh oh!

nickvergessen commented Jun 16, 2020

Uh oh!

nickvergessen commented Jun 19, 2020

Uh oh!

danxuliu left a comment

Uh oh!

This comment has been minimized.

danxuliu left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

"409 Conflict" on joining a second time in the same conversation #3591

"409 Conflict" on joining a second time in the same conversation #3591

Uh oh!

Conversation

nickvergessen commented May 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickvergessen commented May 29, 2020

Uh oh!

nickvergessen commented May 29, 2020

Uh oh!

Uh oh!

nickvergessen commented Jun 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickvergessen commented Jun 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickvergessen commented Jun 16, 2020

Uh oh!

nickvergessen commented Jun 19, 2020

Uh oh!

danxuliu left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

danxuliu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nickvergessen commented May 15, 2020 •

edited

Loading

nickvergessen commented Jun 15, 2020 •

edited

Loading

nickvergessen commented Jun 16, 2020 •

edited

Loading