use break not continue in switch to avoid warning #22175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <[email protected]>
This comment has been minimized.
This comment has been minimized.
rullzer
approved these changes
Aug 10, 2020
Contributor
|
since the switch is in a loop I think |
tofuSCHNITZEL
approved these changes
Aug 11, 2020
Contributor
tofuSCHNITZEL
left a comment
tofuSCHNITZEL
left a comment
There was a problem hiding this comment.
since the switch is in a loop I think continue 2 would be "more correct" but break has the same effect in this case.
Member
Author
yes, same effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this today when using occ. The warning behaviour was introduced with #16737, no biggie.