Skip to content

use break not continue in switch to avoid warning #22175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 1 commit into from
Aug 11, 2020
Merged

use break not continue in switch to avoid warning #22175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/user_ldap/lib/Group_LDAP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,22 +877,22 @@ public function usersInGroup($gid, $search = '', $limit = -1, $offset = 0) {
])
]);
$ldap_users = $this->access->fetchListOfUsers($filter, $attrs, 1);
if (count($ldap_users) < 1) {
continue;
if (empty($ldap_users)) {
break;
}
$groupUsers[] = $this->access->dn2username($ldap_users[0]['dn'][0]);
break;
default:
//we got DNs, check if we need to filter by search or we can give back all of them
$uid = $this->access->dn2username($member);
if (!$uid) {
continue;
break;
}

$cacheKey = 'userExistsOnLDAP' . $uid;
$userExists = $this->access->connection->getFromCache($cacheKey);
if ($userExists === false) {
continue;
break;
}
if ($userExists === null || $search !== '') {
if (!$this->access->readAttribute($member,
Expand All @@ -904,7 +904,7 @@ public function usersInGroup($gid, $search = '', $limit = -1, $offset = 0) {
if ($search === '') {
$this->access->connection->writeToCache($cacheKey, false);
}
continue;
break;
}
$this->access->connection->writeToCache($cacheKey, true);
}
Expand Down