Skip to content

Fix installing on Oracle #22643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Sep 7, 2020
Merged

Fix installing on Oracle #22643

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e3c4f9
Fix installing on Oracle
nickvergessen Sep 7, 2020
5023084
Warn about adding NotNull columns with nullable default
nickvergessen Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix installing on Oracle 
Empty strings are stored as null in Oracle,
so a column with NotNull can not have an empty string as default

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Sep 7, 2020
commit 5e3c4f96090e926916b06a52580bbba2a60a4555
4 changes: 3 additions & 1 deletion core/Migrations/Version18000Date20190920085628.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
$table->addColumn('displayname', Types::STRING, [
'notnull' => true,
'length' => 255,
'default' => '',
// Will be overwritten in postSchemaChange, but Oracle can not save
// empty strings in notnull columns
'default' => 'name',
]);
}

Expand Down