Skip to content

Adjust scroll container height to make it a proper boundary element for actions #22999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Sep 29, 2020
Merged

Adjust scroll container height to make it a proper boundary element for actions #22999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/settings/css/settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,6 +1443,8 @@ doesnotexist:-o-prefocus, .strengthify-wrapper {
$grid-row-height: 60px;
$grid-col-min-width: 160px;
overflow-x: scroll;
Copy link
Member

@raimund-schluessler raimund-schluessler Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note: Why is this overflow-x: scroll here? On my setup, it only creates an empty x-scrollbar, but I can't figure out what needs explicit x-scrolling in settings.

Copy link
Member

@raimund-schluessler raimund-schluessler Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the PR #19533 and the commit 3be571c which added this. I guess it's necessary to fix something. 🙈

min-height: 100%;
height: auto;

#app-content.user-list-grid {
display: grid;
Expand Down