Adjust scroll container height to make it a proper boundary element for actions #22999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
added
bug
design
juliusknorr
requested review from
ChristophWurst,
marcoambrosini,
raimund-schluessler and
skjnldsv
ChristophWurst
approved these changes
Sep 22, 2020
raimund-schluessler
approved these changes
Sep 23, 2020
Member
raimund-schluessler
left a comment
raimund-schluessler
left a comment
There was a problem hiding this comment.
Works as it should. I couldn't find any side effects. 👍
| #body-settings { | ||
| $grid-row-height: 60px; | ||
| $grid-col-min-width: 160px; | ||
| overflow-x: scroll; |
Member
There was a problem hiding this comment.
On a side note: Why is this overflow-x: scroll here? On my setup, it only creates an empty x-scrollbar, but I can't figure out what needs explicit x-scrolling in settings.
Member
…or actions Signed-off-by: Julius Härtl <[email protected]>
rullzer
force-pushed
the
bugfix/noid/settings-container-height
branch
from
3ab36f1 to
92ab659
Compare
Member
|
rebased then lets get it in |
Member
|
/backport to stable20 |
marcoambrosini
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More general approach to replace #22998
Before:
See no menu (since it has boundaries to the body element which is out of the visible area)
After:
See the menu
See nextcloud-libraries/nextcloud-vue#1384 for the background of this issue.