Fix undefined index and consequential damages in versions code #23295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
MorrisJobke,
icewind1991 and
nickvergessen
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
rullzer
approved these changes
Oct 8, 2020
Contributor
|
Make sense. I also think there are some reports around for this. |
nickvergessen
requested changes
Oct 9, 2020
Member
|
@ChristophWurst I added a commit that added the changes the @nickvergessen proposed, because I think that is the better approach to deal with this. |
nickvergessen
approved these changes
Oct 12, 2020
Member
|
DB tests are not happy. Seems to be the "random fail" but it failed on all DBs here, so not sure its unrelated? |
Member
Author
Unfortunately also happening with other PRs right now |
If the user has no space and there are no versions, there won't be an `all` index in the versions entry. Hence this triggers a warning and becomes `null`, afterwards `count`, `foreach` and friends will happily throw even more warnings and errors because they don't want to play with `null`. Thus adding a fallback to an empty array. Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
fix/versions-no-space-no-versions-undefined-index
branch
from
28cd924 to
6ce05bc
Compare
Member
Fixed with #23391 |
MorrisJobke
added
4. to release
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34039: failuresqliteShow full logmysql8.0-php7.4
|
MorrisJobke
deleted the
fix/versions-no-space-no-versions-undefined-index
branch
This was referenced Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has no space and there are no versions, there won't be an
allindex in the versions entry. Hence this triggers a warning andbecomes
null, afterwardscount,foreachand friends will happilythrow even more warnings and errors because they don't want to play with
null. Thus adding a fallback to an empty array.