Only build JSConfig in TemplateLayout when it is actually used #23888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
ChristophWurst,
blizzz,
juliusknorr and
rullzer
rullzer
approved these changes
Nov 4, 2020
blizzz
approved these changes
Nov 4, 2020
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
fix/noid/only-fetch-jsconfig-when-used
branch
from
2dfaa9c to
83c6049
Compare
Member
Author
|
@juliushaertl pointed out that this is on purpose - so I changed this PR to document this inline: #22636 |
MorrisJobke
added
4. to release
juliusknorr
approved these changes
Nov 4, 2020
ChristophWurst
approved these changes
Nov 4, 2020
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Tested and the performance is insane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.