Skip to content

use in objectstore copy #23912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Nov 25, 2020
Merged

use in objectstore copy #23912

rullzer merged 1 commit into from
Nov 25, 2020

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Nov 5, 2020

Signed-off-by: Robin Appelman [email protected]

@icewind1991 icewind1991 added the 2. developing Work in progress label Nov 5, 2020
@rullzer
Copy link
Member

rullzer commented Nov 6, 2020

Is this copy actually called when you do a COPY on webdav?

@nextcloud nextcloud deleted a comment from faily-bot bot Nov 6, 2020
@icewind1991
Copy link
Member Author

icewind1991 commented Nov 9, 2020

Is this copy actually called when you do a COPY on webdav?

yes

@icewind1991
use in objectstore copy
9d4848e 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 24, 2020
@icewind1991 icewind1991 added this to the Nextcloud 21 milestone Nov 24, 2020
@icewind1991
Copy link
Member Author

icewind1991 commented Nov 24, 2020

Is this copy actually called when you do a COPY on webdav?

yes

Spoke to soon, there are of course other code paths

@icewind1991
Copy link
Member Author

icewind1991 commented Nov 24, 2020

#24358 fixes that

@rullzer rullzer merged commit 2172432 into master Nov 25, 2020
@rullzer rullzer deleted the objectstore-copy branch November 25, 2020 15:09
@icewind1991
Copy link
Member Author

icewind1991 commented Dec 7, 2020

/backport to stable20

@icewind1991
Copy link
Member Author

icewind1991 commented Dec 7, 2020

/backport to stable19

This was referenced Dec 7, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: external storage feature: object storage

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @rullzer @ChristophWurst