use storage copy implementation when doing dav copy #24358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using the sabredav fallback (which does a read+write stream copy) this greatly speeds up dav copies Signed-off-by: Robin Appelman <[email protected]>
Member
|
No need to also set it on the File? But I suspect it should speedup copies all around right? As even with local storage you just say to the OS. Copy this there. |
Member
Author
sabredav always call the copy for the parent directory of the target from what I can tell
Should be yes |
rullzer
approved these changes
Dec 3, 2020
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
This was referenced Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using the sabredav fallback (which does a read+write stream copy)
this greatly speeds up dav copies
Signed-off-by: Robin Appelman [email protected]