Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 26, 2020

Previously there was no (platform) dependency check for an app that was
installed before. So Nextcloud happily upgraded an app that now requires
a php version newer than the current one. Which means in the lucky case
you see a failing upgrade due to the language incompatibility, or in the
unlucky case you see unexpected errors later in production.

Todo

  • Adjust app store update to only pull apps that are compatible Check php compatibility of app store app releases #24416
  • See if it's possible to just disable an app that was replaced manually and therefore can't be updated I'd say if someone replaces manually and this logic is in place we stop before anything bad could happen. And the instance is in maintenance mode until the update anyway. So there isn't much we can do.

Fixes nextcloud/mail#4063

Previously there was no (platform) dependency check for an app that was
installed before. So Nextcloud happily upgraded an app that now requires
a php version newer than the current one. Which means in the lucky case
you see a failing upgrade due to the language incompatibility, or in the
unlucky case you see unexpected errors later in production.

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the fix/do-not-update-incompatible-app branch from 0600241 to cbb34af Compare December 4, 2020 16:05
@faily-bot
Copy link

faily-bot bot commented Dec 4, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 218: failure

mariadb10.4-php7.4

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Repair\RepairMimeTypesTest::testRenameWindowsProgramTypes
Failed asserting that null matches expected 'text/plain'.

/drone/src/tests/lib/Repair/RepairMimeTypesTest.php:95
/drone/src/tests/lib/Repair/RepairMimeTypesTest.php:112
/drone/src/tests/lib/Repair/RepairMimeTypesTest.php:150

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 8, 2020
@nickvergessen nickvergessen merged commit c8e0f30 into master Dec 9, 2020
@nickvergessen nickvergessen deleted the fix/do-not-update-incompatible-app branch December 9, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: apps management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mail body displays Nextcloud banner instead of body content

4 participants